[PATCH] D148042: [MSP430] Get the DWARF pointer size from MCAsmInfo instead of DataLayout.
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 21 10:22:30 PDT 2023
dblaikie added a comment.
> If the patch just fixes what was overlooked, then changing directly is the way to go.
The hope/desire would be to make it harder to overlook, by not having the DWARF code reach out to these various config places & just have to "know" which one was the right one - but have it handled once in DwarfDebug and then only consult that everywhere else.
Could you look up the original commits that overlooked this and include references to them here? It'd help provide context for this change for both the review and commit/history later on. (explain how we got here, demonstrate these were overlooked/the changes proposed are consistent with that previous work, etc)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148042/new/
https://reviews.llvm.org/D148042
More information about the llvm-commits
mailing list