[PATCH] D122918: [RISCV][CodeGen] Support Zfinx, Zdinx, Zhinx, Zhinxmin codegen

Shao-Ce SUN via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 21 08:38:21 PDT 2023


sunshaoce added a comment.

In D122918#4287273 <https://reviews.llvm.org/D122918#4287273>, @asb wrote:

> In D122918#4285895 <https://reviews.llvm.org/D122918#4285895>, @sunshaoce wrote:
>
>> We plan to split this patch into the following four parts:
>>
>> - zfinx
>> - zdinx on rv32
>> - zdinx on rv64
>> - zhinx, zhinxmin
>>
>> And, we will address Jessica’s comments in the new patch. Thanks!
>
> Thank you - I think this is a piece of work where you need to have implemented everything to be sure that your approach works, but splitting to allow reviewing it in smaller chunks will be much better.

Thanks, we will make sure to do it well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122918/new/

https://reviews.llvm.org/D122918



More information about the llvm-commits mailing list