[PATCH] D148916: [Support][Parallel] Initialize threadIndex and add assertion checking its usage.

Andrew Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 21 08:29:23 PDT 2023


andrewng added inline comments.


================
Comment at: llvm/lib/Support/Parallel.cpp:225
-  auto NumItems = End - Begin;
-  if (NumItems > 1 && parallel::strategy.ThreadsRequested != 1) {
     // Limit the number of tasks to MaxTasksPerGroup to limit job scheduling
----------------
The following is the commit for which the `NumItems <= 1` case was important: 5fa9d416 "[Support/Parallel] Add a special case for 0/1 items to llvm::parallel_for_each.". I don't know if it's still important but probably should be checked.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148916/new/

https://reviews.llvm.org/D148916



More information about the llvm-commits mailing list