[PATCH] D148866: [CMake][AIX] Fixing AIX rpath

Fri Apr 21 07:56:54 PDT 2023

qiongsiwu1 added a comment.

In D148866#4287133 <https://reviews.llvm.org/D148866#4287133>, @buttaface wrote:

> Ah, sorry, I solicited feedback on the AIX changes on the original review, but got none. You will also want to undo the split of the AIX rpaths I put in above, moving everything to `_install_rpath` instead.
>
> Also, do you mind removing Windows from this list? I'm fairly certain that has no effect, as the logic above returns if not an Apple, Unix, or AIX platform, but I simply put it in because of a previous LLVM commit message for 959dbd1761c <https://reviews.llvm.org/rG959dbd1761cddbe8c53509459dbc0463f86c1b50> that reported this same error on Windows, likely erroneously.

Thanks for the feedback @buttaface !! The engineer pinged in the original patch is no longer working on AIX. The patch is updated.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148866/new/

https://reviews.llvm.org/D148866