[PATCH] D148906: [AMDGPU] Remove incompatible attributes of function in amdgpu-remove-incompatible-functions pass

Fri Apr 21 07:55:20 PDT 2023

b-sumner added a comment.

In D148906#4287110 <https://reviews.llvm.org/D148906#4287110>, @foad wrote:

> In D148906#4286903 <https://reviews.llvm.org/D148906#4286903>, @arsenm wrote:
>
>> In D148906#4286691 <https://reviews.llvm.org/D148906#4286691>, @foad wrote:
>>
>>>> Currently, wavfrontsize32 is being appended by device-libs to some functions for gfx9 targets.
>>>
>>> Why? That seems wrong.
>>
>> It is wrong but that’s how the library is currently structured. All code coexists in the same IR, and there are some wave32 only functions
>
> But if you're compiling for gfx900 then this pass should remove any functions that are marked with +wavefrontsize32. It should not just remove the +wavefrontsize32 from the function.

I thought we had agreed that we were going to eliminate the body of incompatible functions and that had been implemented.  If that is not enough, then maybe we should strip the problematic attributes of such functions as well?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148906/new/

https://reviews.llvm.org/D148906