[PATCH] D148905: [Vectorize] Fix vectorization and folding of llvm.is.fpclass

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Similar to D132344 <https://reviews.llvm.org/D132344>, but it look like this patch has stalled.



================
Comment at: llvm/lib/Analysis/VectorUtils.cpp:131
   default:
-    return false;
+    return OpdIdx == -1;
   }
----------------
I'm not sure about the change in the default here, IICU this is now considering any other intrinsic to have the return type overloaded?


================
Comment at: llvm/test/Transforms/LoopVectorize/ARM/is_fpclass.ll:4
+
+target triple = "aarch64-unknown-linux-gnu"
+
----------------
The triple doesn't match the sub-directory, `aarch64-` needs to be in the `AArch64` subdirectory.

But does the test need to be target specific in the first place? Could you just use `-force-vector-width=4 -force-vector-interleave=1` or something, without a triple?

Also, would be good to add the test separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148905/new/

https://reviews.llvm.org/D148905