[PATCH] D148118: [AArch64][DAGCombiner]: combine <2xi64> mul add/sub.

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm accepted this revision.
paulwalker-arm added a comment.

Looks good to me but please add a couple of tests to show the new operand flexibility before landing the patch.  For example:

  define <2 x i64> @test(<2 x i64> %a, <2 x i64> %b, <2 x i64> %c, <2 x i64> %d) {
    %mul1 = mul <2 x i64> %a, %b
    %mul2= mul <2 x i64> %c, %d
    %sub = sub <2 x i64> %mul, %mul2
    ret <2 x i64> %sub
  }


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148118/new/

https://reviews.llvm.org/D148118