[PATCH] D148921: [llvm-exegesis] Use MCJIT only for execution

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: llvm/test/tools/llvm-exegesis/PowerPC/lit.local.cfg:4-6
-elif not ('powerpc' in config.root.host_triple):
-    # We need to be running on an PPC host.
-    config.unsupported = True
----------------
Maybe do this in a separate patch in case it has to be reverted ? :)


================
Comment at: llvm/tools/llvm-exegesis/lib/Assembler.cpp:345
+  auto SectionOrErr = Functions.front().getSection();
+  if (!SectionOrErr || *SectionOrErr == Obj->section_end())
+    return make_error<Failure>("Section not found");
----------------
[nit] Propagate the error ?


================
Comment at: llvm/tools/llvm-exegesis/lib/Assembler.cpp:348
+#ifndef NDEBUG
+  auto Address = Functions.front().getAddress();
+  assert(Address && *Address == 0 && "Unexpected layout");
----------------
I'm not very familiar with the section API, is this the relative address of the symbol within the section or an absolute address ? If the latter should this be compared to `SectionRef::getAddress()` rather than 0 ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148921/new/

https://reviews.llvm.org/D148921