[PATCH] D148859: [ELF] Add --remap-inputs-file=

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 21 06:12:43 PDT 2023


peter.smith added a comment.

Code that is here looks good to me. I agree with melver that we shouldn't assume the presence of bash/zsh, particularly for Windows users. I can't comment on how necessary the command line version is, to me writing a file is an extra step that I may have to do if I just want a quick experiment, but that is more of an inconvenience. However a build system may be so difficult that adding an extra file without it being checked in somewhere might exist.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148859/new/

https://reviews.llvm.org/D148859



More information about the llvm-commits mailing list