[PATCH] D148906: [AMDGPU] Remove incompatible attributes of function in amdgpu-remove-incompatible-functions pass

Fri Apr 21 06:03:35 PDT 2023

yaxunl added a comment.

In D148906#4286903 <https://reviews.llvm.org/D148906#4286903>, @arsenm wrote:

> In D148906#4286691 <https://reviews.llvm.org/D148906#4286691>, @foad wrote:
>
>>> Currently, wavfrontsize32 is being appended by device-libs to some functions for gfx9 targets.
>>
>> Why? That seems wrong.
>
> It is wrong but that’s how the library is currently structured. All code coexists in the same IR, and there are some wave32 only functions

One concern is whether removing +wavefrontsize32 will make them work. They may contain an instruction sequence that only works with wavefront size 32.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148906/new/

https://reviews.llvm.org/D148906