[PATCH] D148720: [IRCE] Refactor parseRangeCheckICmp
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 21 03:33:20 PDT 2023
This revision was automatically updated to reflect the committed changes.
Closed by commit rG88da59682004: [IRCE][NFCI] Refactor parseRangeCheckICmp (authored by mkazantsev).
Changed prior to commit:
https://reviews.llvm.org/D148720?vs=515653&id=515672#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148720/new/
https://reviews.llvm.org/D148720
Files:
llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp
Index: llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp
===================================================================
--- llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp
+++ llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp
@@ -264,46 +264,37 @@
Value *LHS = ICI->getOperand(0);
Value *RHS = ICI->getOperand(1);
+ // Canonicalize to the `Index Pred Invariant` comparison
+ if (IsLoopInvariant(LHS)) {
+ std::swap(LHS, RHS);
+ Pred = CmpInst::getSwappedPredicate(Pred);
+ } else if (!IsLoopInvariant(RHS))
+ // Both LHS and RHS are loop variant
+ return false;
+
switch (Pred) {
default:
return false;
- case ICmpInst::ICMP_SLE:
- std::swap(LHS, RHS);
- [[fallthrough]];
case ICmpInst::ICMP_SGE:
if (match(RHS, m_ConstantInt<0>())) {
Index = SE.getSCEV(LHS);
- return true; // Lower.
+ return true;
}
return false;
- case ICmpInst::ICMP_SLT:
- std::swap(LHS, RHS);
- [[fallthrough]];
case ICmpInst::ICMP_SGT:
if (match(RHS, m_ConstantInt<-1>())) {
Index = SE.getSCEV(LHS);
- return true; // Lower.
- }
-
- if (IsLoopInvariant(LHS)) {
- Index = SE.getSCEV(RHS);
- End = SE.getSCEV(LHS);
- return true; // Upper.
+ return true;
}
return false;
+ case ICmpInst::ICMP_SLT:
case ICmpInst::ICMP_ULT:
- std::swap(LHS, RHS);
- [[fallthrough]];
- case ICmpInst::ICMP_UGT:
- if (IsLoopInvariant(LHS)) {
- Index = SE.getSCEV(RHS);
- End = SE.getSCEV(LHS);
- return true; // Both lower and upper.
- }
- return false;
+ Index = SE.getSCEV(LHS);
+ End = SE.getSCEV(RHS);
+ return true;
}
llvm_unreachable("default clause returns!");
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148720.515672.patch
Type: text/x-patch
Size: 1760 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230421/70a59be8/attachment.bin>
More information about the llvm-commits
mailing list