[PATCH] D148815: [Coverity] Fix uninitialized scalar members in TableGen

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 22:39:21 PDT 2023


skan added inline comments.


================
Comment at: llvm/utils/TableGen/DXILEmitter.cpp:29
 struct DXILShaderModel {
-  int Major;
-  int Minor;
+  int Major = -1;
+  int Minor = -1;
----------------
Why `-1`? zero initializer seems more reasonable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148815/new/

https://reviews.llvm.org/D148815



More information about the llvm-commits mailing list