[PATCH] D148868: [llvm-profdata] ProfileReader cleanup - preparation for MD5 refactoring

William Junda Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 18:54:38 PDT 2023


huangjd created this revision.
Herald added subscribers: wenlei, hiraditya.
Herald added a project: All.
huangjd requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Cleanup profile reader classes to prepare for complex refactoring as propsed in D147740 <https://reviews.llvm.org/D147740> (Use MD5 as key for profile map). Change is too complicated so I am cleaning up the reader implementation first with these goals.

- Reduce duplicated/similar logic
- Reduce virtual functions, changing them to non-virtual
- Reduce unnecessry checks, indirections, and dead writes.

This is patch 1/n. This patch refactors NameTable


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D148868

Files:
  llvm/include/llvm/ProfileData/SampleProfReader.h
  llvm/lib/ProfileData/SampleProfReader.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148868.515556.patch
Type: text/x-patch
Size: 14731 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230421/dccef978/attachment.bin>


More information about the llvm-commits mailing list