[PATCH] D148866: [CMake][AIX] Fixing AIX rpath

Qiongsi Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 18:17:17 PDT 2023


qiongsiwu1 created this revision.
Herald added a subscriber: ekilmer.
Herald added a project: All.
qiongsiwu1 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Recent commit https://github.com/llvm/llvm-project/commit/8f833f88ab78265a8e0ebb0d1522771d67c708a9 modified the installation rpath and did not set `BUILD_WITH_INSTALL_RPATH` correctly on AIX, which led to installation failures on AIX. This patch sets `BUILD_WITH_INSTALL_RPATH` on AIX to fix the installation failure.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D148866

Files:
  llvm/cmake/modules/AddLLVM.cmake


Index: llvm/cmake/modules/AddLLVM.cmake
===================================================================
--- llvm/cmake/modules/AddLLVM.cmake
+++ llvm/cmake/modules/AddLLVM.cmake
@@ -2357,7 +2357,7 @@
   # Enable BUILD_WITH_INSTALL_RPATH unless CMAKE_BUILD_RPATH is set and not
   # building for macOS or Windows, as those two platforms seemingly require it.
   if("${CMAKE_BUILD_RPATH}" STREQUAL "")
-    if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin|Windows")
+    if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin|Windows|AIX")
       set_property(TARGET ${name} PROPERTY BUILD_WITH_INSTALL_RPATH ON)
     else()
       set_property(TARGET ${name} APPEND PROPERTY BUILD_RPATH "${_build_rpath}")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148866.515552.patch
Type: text/x-patch
Size: 685 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230421/f7669cdc/attachment.bin>


More information about the llvm-commits mailing list