[PATCH] D148852: [Demangle] fix windows tests
Nick Desaulniers via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 20 15:57:04 PDT 2023
nickdesaulniers added inline comments.
================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:811
- std::string_view MD5(Start, &*MangledName.begin() - Start);
+ const size_t Count = MangledName.size() - StartSize;
+ std::string_view MD5(Start, Count);
----------------
I think this is potentially backwards. I'll add some asserts and flip it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148852/new/
https://reviews.llvm.org/D148852
More information about the llvm-commits
mailing list