[PATCH] D148821: [SystemZ][z/OS] Create utility functions for converting between EBCDIC and UTF-8.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 20 15:49:06 PDT 2023
efriedma added inline comments.
================
Comment at: llvm/include/llvm/Support/ConvertEBCDIC.h:6
+namespace llvm {
+namespace ConverterEBCDIC {
+std::error_code convertToEBCDIC(StringRef Source,
----------------
Probably should indicate in the header somewhere precisely what encoding this uses; there are a number of different "EBCDIC" encodings (although probably most of them are irrelevant these days).
================
Comment at: llvm/lib/Support/ConvertEBCDIC.cpp:109
+ // To maintain common behaviour as convertWithIconv since that overwites
+ // the output buffer.
+ Result.clear();
----------------
Out-of-date comment?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148821/new/
https://reviews.llvm.org/D148821
More information about the llvm-commits
mailing list