[PATCH] D147734: [LV][NFC] Precommit test for a follow-up patch that introduces uniformity for a specific VF.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 13:38:01 PDT 2023


fhahn added a comment.

I think it would be good to extend test coverage by adding tests with 1) multiple inductions, 2) different induction start values (different constants, maybe a function argument), 3) different divisors (including a non-power-of-2 one)



================
Comment at: llvm/test/Transforms/LoopVectorize/X86/uniform_across_vf.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 2
+; RUN: opt -mtriple=x86_64-unknown-linux -mcpu=skx -passes=loop-vectorize -force-vector-interleave=1 -force-vector-width=2 %s -S | FileCheck %s
+
----------------
Does the test have to be X86 specific or could it be generic?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147734/new/

https://reviews.llvm.org/D147734



More information about the llvm-commits mailing list