[PATCH] D148836: [X86] Use "l" prefix for data sections under medium/large code model

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 13:16:34 PDT 2023


aeubanks created this revision.
Herald added subscribers: pengfei, hiraditya.
Herald added a project: All.
aeubanks requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

And also set the SHF_X86_64_LARGE section flag.

gcc only uses the "l" prefix and SHF_X86_64_LARGE in the medium code model for data larger than -mlarge-data-threshold. But it seems more consistent to use it in the large code model as well in case separate parts of the binary aren't compiled with the large code model and also have a .data/.bss/.rodata section.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D148836

Files:
  llvm/include/llvm/Target/TargetMachine.h
  llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
  llvm/lib/Target/TargetMachine.cpp
  llvm/test/CodeGen/X86/code-model-elf-sections.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148836.515452.patch
Type: text/x-patch
Size: 5742 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230420/9af34260/attachment.bin>


More information about the llvm-commits mailing list