[PATCH] D147545: [CSSPGO] Stale profile matching(part 2)
Lei Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 20 12:55:30 PDT 2023
wlei added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:2339
+ if (ReportProfileStaleness || PersistProfileStaleness) {
+ uint64_t _TotalProfiledCallsites = TotalProfiledCallsites;
+ uint64_t _NumMismatchedCallsites = NumMismatchedCallsites;
----------------
wenlei wrote:
> A bit confused by the use of `_TotalProfiledCallsites` and `_NumMismatchedCallsites`, what are you trying to do with the two additional variables?
Because the `TotalProfiledCallsites` and `NumMismatchedCallsites` is the sum for the whole module functions not one function, so here for function level debug print, use a location variable to do it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147545/new/
https://reviews.llvm.org/D147545
More information about the llvm-commits
mailing list