[PATCH] D148483: [RISCV] Zvk (vector crypto) specification update to 0.5.1 (Zvbb/Zvbc/Zvkt/Zvkng/Zvksg)
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 20 10:43:52 PDT 2023
asb added a comment.
In D148483#4283898 <https://reviews.llvm.org/D148483#4283898>, @ego wrote:
> Thanks for the clarification. I went with the additional alignment. I used to overdo vertical alignment but it was beaten out of me by the Google C++ style guide and automatic formatters.
Yes, once there's a decent .td auto-formatting solution I'll probably miss some of the niceties of manually aligned instruction definitions, but it will also be nice to spend less review time going back and forth on whitespace :)
Thanks for the rapid iteration on this - I've now landed the patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148483/new/
https://reviews.llvm.org/D148483
More information about the llvm-commits
mailing list