[PATCH] D148269: [Pipeline] Don't limit ArgumentPromotion to -O3

[Zequan Wu via Phabricator via llvm-commits]

zequanwu added a comment.

Hi, this causes test failures on chromium's crashpad_tests.

  Note: Google Test filter = StartHandlerForSelfTestSuite/StartHandlerForSelfTest.StartHandlerInChild/94
  [==========] Running 1 test from 1 test suite.
  [----------] Global test environment set-up.
  [----------] 1 test from StartHandlerForSelfTestSuite/StartHandlerForSelfTest
  [ RUN      ] StartHandlerForSelfTestSuite/StartHandlerForSelfTest.StartHandlerInChild/94
  ERROR crashpad_tests[4189468:4189468]: [file_io.cc(94)] ReadExactly: expected 1, observed 0
  ../../third_party/crashpad/crashpad/client/crashpad_client_linux_test.cc:474: Failure
  Value of: LoggingReadFileExactly(ReadPipeHandle(), &c, sizeof(c))
    Actual: false
  Expected: true
  Stack trace:
  #0 0x55ac0ffc6334 crashpad::test::(anonymous namespace)::StartHandlerForSelfInChildTest::MultiprocessParent()
  #1 0x55ac1033b844 crashpad::test::Multiprocess::RunParent()
  #2 0x55ac1033b322 crashpad::test::Multiprocess::Run()
  #3 0x55ac0ffc5cb7 crashpad::test::(anonymous namespace)::StartHandlerForSelfTest_StartHandlerInChild_Test::TestBody()
  
  ../../third_party/crashpad/crashpad/client/crashpad_client_linux_test.cc:494: Failure
  Expected equality of these values:
    reports.size()
      Which is: 0
    report_expected ? 1u : 0u
      Which is: 1
  Stack trace:
  #0 0x55ac0ffc666f crashpad::test::(anonymous namespace)::StartHandlerForSelfInChildTest::MultiprocessParent()
  #1 0x55ac1033b844 crashpad::test::Multiprocess::RunParent()
  #2 0x55ac1033b322 crashpad::test::Multiprocess::Run()
  #3 0x55ac0ffc5cb7 crashpad::test::(anonymous namespace)::StartHandlerForSelfTest_StartHandlerInChild_Test::TestBody()
  
  ../../third_party/crashpad/crashpad/test/multiprocess_posix.cc:139: Failure
  Failed
  Child exited with code 0, expected termination by signal 11 (Segmentation fault)
  Stack trace:
  #0 0x55ac1033b733 crashpad::test::Multiprocess::Run()
  #1 0x55ac0ffc5cb7 crashpad::test::(anonymous namespace)::StartHandlerForSelfTest_StartHandlerInChild_Test::TestBody()
  
  [  FAILED  ] StartHandlerForSelfTestSuite/StartHandlerForSelfTest.StartHandlerInChild/94, where GetParam() = (true, false, true, true, true, 4-byte object <02-00 00-00>) (6 ms)
  [----------] 1 test from StartHandlerForSelfTestSuite/StartHandlerForSelfTest (6 ms total)
  
  [----------] Global test environment tear-down
  [==========] 1 test from 1 test suite ran. (6 ms total)
  [  PASSED  ] 0 tests.
  [  FAILED  ] 1 test, listed below:
  [  FAILED  ] StartHandlerForSelfTestSuite/StartHandlerForSelfTest.StartHandlerInChild/94, where GetParam() = (true, false, true, true, true, 4-byte object <02-00 00-00>)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148269/new/

https://reviews.llvm.org/D148269