[PATCH] D148483: RISC-V Zvk (vector crypto) specification update to 0.5.1 (Zvbb/Zvbc/Zvkt/Zvkng/Zvksg)

Thu Apr 20 08:57:38 PDT 2023

ego added a comment.

In D148483#4282761 <https://reviews.llvm.org/D148483#4282761>, @asb wrote:

> In D148483#4282342 <https://reviews.llvm.org/D148483#4282342>, @ego wrote:
>
>> I do not have commit access. I propose that, if everything looks good, I'll upload a rebased version and let someone (Alex?)  commit on my behalf?
>> Let me know if there is a better way.
>
> Yep, that's the usual way. Just indicate when it's ready for commit from your perspective and confirm the name + email address and one of us can commit. Whoever is around at the time and has been following this patch really - I believe we're in a different timezone but I'll happily commit if no-one beats me to it when you indicate it's ready.

Sounds good to me. The commit is ready from my point of view. Please use  Eric Gouriou <ego at rivosinc.com>.

> See https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access for details on obtaining commit access yourself - I'd suggest you email Chris after another landing another couple patches or so.

Sounds good, will do.

> We often do add additioanl space before the : even though it has the disadvantage you mention of risking NFC changes if new identifiers are added. It has the advantage that when scanning definitions inheriting from the same class, the differences in class parameters are easier to spot as they're aligned (e.g. the changing bit pattern).

Thanks for the clarification. I went with the additional alignment. I used to overdo vertical alignment but it was beaten out of me by the Google C++ style guide and automatic formatters.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148483/new/

https://reviews.llvm.org/D148483