[PATCH] D148795: [ELF] Support --remap-inputs and --remap-inputs-file

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 08:38:20 PDT 2023


peter.smith added a comment.

I don't have a strong opinion on this one. I prefer the more general approachof this patch than the previous patch of filtering out files.

One thing we may want to be careful of is the use of wildcards. IIUC the only valid use is in the pattern and not the replacement, so we end up with many to one mappings. I can see these being OK for /dev/null and libraries but many to one for an object file would likely cause multiply defined symbol errors. Not entirely sure what we can do about that given we're looking at names.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148795/new/

https://reviews.llvm.org/D148795



More information about the llvm-commits mailing list