[PATCH] D148792: LangRef: Clarify behavior of minnum/maxnum

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 05:51:19 PDT 2023


nikic added a comment.

In D148792#4283393 <https://reviews.llvm.org/D148792#4283393>, @arsenm wrote:

> In D148792#4283350 <https://reviews.llvm.org/D148792#4283350>, @nikic wrote:
>
>> Not sure I follow. If a NaN is returned, the NaN will always be quiet.
>
> This is distinguishing quiet and signaling nans. Not only is this inconsistent with the IR policy for unconstrained FP operations, it's not the behavior of libm fmin/fmax.
>
> These intrinsics have the fmin/fmax behavior and were incorrectly named. The first sentence describes the IEEE754 behavior, and the second paragraph elaborates that they do not.

I see, thanks for the explanation!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148792/new/

https://reviews.llvm.org/D148792



More information about the llvm-commits mailing list