[PATCH] D148345: [FuncSpec] Relax restrictions on candidates for specialisation

Thu Apr 20 05:45:23 PDT 2023

labrinea added a comment.

In D148345#4283318 <https://reviews.llvm.org/D148345#4283318>, @nikic wrote:

> In D148345#4272354 <https://reviews.llvm.org/D148345#4272354>, @labrinea wrote:
>
>> I've checked the number of specializations created for CTMark with this patch. No changes there so I am not expecting a compile time hit. Approved.
>
> Looks like this assumption wasn't right. There is a compile-time regression (http://llvm-compile-time-tracker.com/compare.php?from=99d4c722e30816aca6698e20345bffab953d9d79&to=cc7bb7080fc8e6f4d217e7f9b971fbdbf091f9e7&stat=instructions:u) and code size changed on lencod (http://llvm-compile-time-tracker.com/compare.php?from=99d4c722e30816aca6698e20345bffab953d9d79&to=cc7bb7080fc8e6f4d217e7f9b971fbdbf091f9e7&stat=size-text).

Right I see now. The compile time regression are without LTO, whereas I had checked only the LTO configuration. I can see three new specializations in lencod.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148345/new/

https://reviews.llvm.org/D148345