[PATCH] D42600: [CodeGen][Shrink-wrap]split restore point

[Sushant Gokhale via Phabricator via llvm-commits]

sushgokh added a comment.

@alexfh @fhahn Thanks for the inputs. Could you please confirm if the regression goes away by applying this?

  @@ -471,7 +471,9 @@ tryToSplitRestore(MachineBasicBlock *MBB,
         MBBFallthrough.insert(BB);   MachineBasicBlock *NMBB = MF->CreateMachineBasicBlock();
  -  MF->insert(MachineFunction::iterator(MBB), NMBB);
  +  // Insert this block at the end of the function. Inserting in between may
  +  // interfere with control flow optimizer decisions.
  +  MF->insert(MF->end(), NMBB);   
     for (const MachineBasicBlock::RegisterMaskPair &LI : MBB->liveins())
       NMBB->addLiveIn(LI.PhysReg);


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D42600/new/

https://reviews.llvm.org/D42600