[PATCH] D148788: [NFC] Return unique dbg intrinsics from findDbgValues and findDbgUsers

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer accepted this revision.
StephenTozer added a comment.

Hopefully the size of the set isn't too high with this change since ordinary dbg.values will appear in the set now too; it should be fine, because there have been previous pathological cases of duplicated DIArgList-using dbg.values, and this function didn't cause major performance issues in those cases IIRC.



================
Comment at: llvm/lib/IR/DebugInfo.cpp:106
+  // V will also appear twice in a dbg.assign if its used in the both the value
+  // and address components
   SmallPtrSet<DbgVariableIntrinsic *, 4> EncounteredDbgValues;
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148788/new/

https://reviews.llvm.org/D148788