[PATCH] D148171: ValueTracking: Implement computeKnownFPClass for fdiv for nan/inf handling

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4514
+
+    const Function *F = cast<Instruction>(Op)->getFunction();
+
----------------
foad wrote:
> nikic wrote:
> > foad wrote:
> > > Could it be an FDiv ConstantExpr?
> > fdiv is not supported in constant expressions anymore.
> Great! I had a quick look but didn't find the commit that removed them, or where to look for an up to date list of supported operators.
For binops in particular it's ConstantExpr::isSupportedBinOp(). It looks like I need to update the listing at https://llvm.org/docs/LangRef.html#constant-expressions with the current state.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148171/new/

https://reviews.llvm.org/D148171