[PATCH] D148709: [LVI][CVP] Don't compute CR at SelectInst Use if Cond value may not be well-defined

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Analysis/LazyValueInfo.cpp:1670-1673
+      // Since Analysing constant range by poison or undef condition value is
+      // not correct and having poison or undef condition value for SelectInst
+      // is not undefined behavior, stop walking if the condition value is not
+      // guaranteed to be well-defined (PR62200).
----------------
This issue is only about undef, it does not affect poison. This is why it's mostly a theoretical problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148709/new/

https://reviews.llvm.org/D148709