[PATCH] D146918: [CMake] Don't set absolute paths as install runpaths on ELF platforms in llvm_setup_rpath()

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

In D146918#4282895 <https://reviews.llvm.org/D146918#4282895>, @buttaface wrote:

> @asb, thanks for letting us know, could you share more info on what platform you are building for? Your CMake error says this is supported on ELF, so you are building on macOS? As you can see in the OP above, @phosek reported a similar error before, so I coded this very defensively to always apply `BUILD_WITH_INSTALL_RPATH` for Mac and Windows. Perhaps this also affects you on other rare configurations, so we will need more info on your config to come up with a fix.

I'm on bog standard Linux (current Arch Linux, on x86_64). The issue occurs when just rerunning `cmake --build .` or `ninja` within my usual debug build directory (i.e. an incremental build). Reverting this patch fixes it. However, I've since tested creating a new build directory and redoing `cmake -G Ninja <stuff I listed in my last message>` and that appears OK. So this is perhaps not a critical issue, though I can't remember the last time I had something similar.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146918/new/

https://reviews.llvm.org/D146918