[PATCH] D148520: [VP] Add more functional SD opcodes to definitions

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 00:17:45 PDT 2023


frasercrmck added a comment.

In D148520#4277378 <https://reviews.llvm.org/D148520#4277378>, @luke wrote:

> So from what I can tell, VPMatchContext can now make VP nodes from FP_EXTEND and FMAD. However there's no observable change because with the former, `TLI.isFPExtFoldable` returns false on RISC-V, and with the latter it's explicitly disabled with a FIXME to re-enable it at some point. 
> But I've removed the NFC anyway: I believe these nodes are equivalent so these folds should be correct if they are ever enabled.

Thanks for checking.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148520/new/

https://reviews.llvm.org/D148520



More information about the llvm-commits mailing list