[PATCH] D147364: [lld][ELF] Support relocations R_AVR_LO8_LDI_GS/R_AVR_HI8_LDI_GS

[Ben Shi via Phabricator via llvm-commits]

benshi001 marked 3 inline comments as done.
benshi001 added inline comments.


================
Comment at: lld/ELF/Arch/AVR.cpp:113
+    // [0, 0x1fffe].
+    assert((s.getVA() & 1) == 0 && "function address must be aligned to 2.");
+    return s.getVA() >= 0x20000;
----------------
MaskRay wrote:
> If `s.getVA() & 1` is not rejected by previous checks, we should not have this check.
> 
> Don't add a period for messages. See https://llvm.org/docs/CodingStandards.html#error-and-warning-messages
The redundant assert is removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147364/new/

https://reviews.llvm.org/D147364