[PATCH] D148483: RISC-V Zvk (vector crypto) specification update to 0.5.1 (Zvbb/Zvbc/Zvkt/Zvkng/Zvksg)

Eric Gouriou via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 19 18:04:34 PDT 2023


ego updated this revision to Diff 515155.
ego marked 5 inline comments as done.
ego edited the summary of this revision.
ego added a comment.

I addressed Brandon's comments as best as I can:

- this version removes the changes that dropped the '.' in the descriptions of the extensions (will propose in a follow-up NFC change). The result is slightly inconsistent as I did not use the '.' in the descriptions of Zvbb/Zvbc, we can figure what option to pick in follow-up.
- the instruction definitions are sorted, hopefully as was suggested,
- I fixed the ordering in the usage doc to be alphabetical,
- I removed unintended trailing whitespace in a whitespace line in zvkg.s .

I did *not* rebase as I wanted to avoid bringing unrelated changes. Based on Alex description (and https://reviews.llvm.org/rG0386546b088a), this should be very simple.

I do not have commit access. I propose that, if everything looks good, I'll upload a rebased version and let someone (Alex?)  commit on my behalf?
Let me know if there is a better way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148483/new/

https://reviews.llvm.org/D148483

Files:
  clang/test/Preprocessor/riscv-target-features.c
  llvm/docs/RISCVUsage.rst
  llvm/lib/Support/RISCVISAInfo.cpp
  llvm/lib/Target/RISCV/RISCVFeatures.td
  llvm/lib/Target/RISCV/RISCVInstrInfoZvk.td
  llvm/test/CodeGen/RISCV/attributes.ll
  llvm/test/MC/RISCV/attribute-arch.s
  llvm/test/MC/RISCV/rvv/zvbb.s
  llvm/test/MC/RISCV/rvv/zvbc.s
  llvm/test/MC/RISCV/rvv/zvkb.s
  llvm/test/MC/RISCV/rvv/zvkg.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148483.515155.patch
Type: text/x-patch
Size: 46105 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230420/e91d4246/attachment-0001.bin>


More information about the llvm-commits mailing list