[PATCH] D148762: [RISCV] Rename some variables to improve code clarity
Nitin John Raj via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 19 17:06:55 PDT 2023
nitinjohnraj added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:117
-class VLSSched<int n, string suffix = "WorstCase"> : Sched<[
- !cast<SchedReadWrite>("WriteVLDS" #n #"_" # suffix),
+class VLSSched<int eew, string lmul = "WorstCase"> : Sched<[
+ !cast<SchedReadWrite>("WriteVLDS" #eew #"_" #lmul),
----------------
Should this string be emul instead of lmul?
================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:122
-class VSSSched<int n, string suffix = "WorstCase"> : Sched<[
- !cast<SchedReadWrite>("WriteVSTS" #n #"_"#suffix),
- !cast<SchedReadWrite>("ReadVSTS" #n #"V_"#suffix),
+class VSSSched<int eew, string lmul = "WorstCase"> : Sched<[
+ !cast<SchedReadWrite>("WriteVSTS" #eew #"_" #lmul),
----------------
Should this string be emul instead of lmul?
================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:130
+ string dataLMUL = "WorstCase",
+ string idxLMUL = "WorstCase"> : Sched<[
+ !cast<SchedReadWrite>("WriteVLD" #isOrdered #"X" #dataEEW #"_" #dataLMUL),
----------------
Should this string be emul instead of lmul?
================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:150
// Unit-Stride Segment Loads and Stores
-class VLSEGSched<int nf, int eew, string suffix = "WorstCase"> : Sched<[
- !cast<SchedReadWrite>("WriteVLSEG" #nf #"e" #eew #"_"#suffix),
+class VLSEGSched<int nf, int eew, string lmul = "WorstCase"> : Sched<[
+ !cast<SchedReadWrite>("WriteVLSEG" #nf #"e" #eew #"_" #lmul),
----------------
Should this string be emul instead of lmul?
================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:154
]>;
-class VSSEGSched<int nf, int eew, string suffix = "WorstCase"> : Sched<[
- !cast<SchedReadWrite>("WriteVSSEG" #nf #"e" #eew #"_"#suffix),
- !cast<SchedReadWrite>("ReadVSTEV_"#suffix),
+class VSSEGSched<int nf, int eew, string lmul = "WorstCase"> : Sched<[
+ !cast<SchedReadWrite>("WriteVSSEG" #nf #"e" #eew #"_" #lmul),
----------------
Should this string be emul instead of lmul?
================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:159
]>;
-class VLSEGFFSched<int nf, int eew, string suffix = "WorstCase"> : Sched<[
- !cast<SchedReadWrite>("WriteVLSEGFF" #nf #"e" #eew #"_"#suffix),
+class VLSEGFFSched<int nf, int eew, string lmul = "WorstCase"> : Sched<[
+ !cast<SchedReadWrite>("WriteVLSEGFF" #nf #"e" #eew #"_" #lmul),
----------------
Should this string be emul instead of lmul?
================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:164
// Strided Segment Loads and Stores
-class VLSSEGSched<int nf, int eew, string suffix = "WorstCase"> : Sched<[
- !cast<SchedReadWrite>("WriteVLSSEG" #nf #"e" #eew #"_"#suffix),
+class VLSSEGSched<int nf, int eew, string lmul = "WorstCase"> : Sched<[
+ !cast<SchedReadWrite>("WriteVLSSEG" #nf #"e" #eew #"_" #lmul),
----------------
Should this string be emul instead of lmul?
================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:168
]>;
-class VSSSEGSched<int nf, int eew, string suffix = "WorstCase"> : Sched<[
- !cast<SchedReadWrite>("WriteVSSSEG" #nf #"e" #eew #"_"#suffix),
- !cast<SchedReadWrite>("ReadVSTS" #eew #"V_"#suffix),
+class VSSSEGSched<int nf, int eew, string lmul = "WorstCase"> : Sched<[
+ !cast<SchedReadWrite>("WriteVSSSEG" #nf #"e" #eew #"_" #lmul),
----------------
Should this string be emul instead of lmul?
================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:174
// Indexed Segment Loads and Stores
-class VLXSEGSched<int nf, int eew, string o, string suffix = "WorstCase"> : Sched<[
- !cast<SchedReadWrite>("WriteVL" #o #"XSEG" #nf #"e" #eew #"_"#suffix),
- ReadVLDX, !cast<SchedReadWrite>("ReadVLD" #o #"XV" #"_"#suffix), ReadVMask
+class VLXSEGSched<int nf, int eew, string isOrdered, string lmul = "WorstCase"> : Sched<[
+ !cast<SchedReadWrite>("WriteVL" #isOrdered #"XSEG" #nf #"e" #eew #"_" #lmul),
----------------
Should this string be emul instead of lmul?
================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:178
]>;
-class VSXSEGSched<int nf, int eew, string o, string suffix = "WorstCase"> : Sched<[
- !cast<SchedReadWrite>("WriteVS" #o #"XSEG" #nf #"e" #eew #"_"#suffix),
- !cast<SchedReadWrite>("ReadVST" #o #"X" #eew # "_"#suffix),
- ReadVSTX, !cast<SchedReadWrite>("ReadVST" #o #"XV" # "_"#suffix), ReadVMask
+class VSXSEGSched<int nf, int eew, string isOrdered, string lmul = "WorstCase"> : Sched<[
+ !cast<SchedReadWrite>("WriteVS" #isOrdered #"XSEG" #nf #"e" #eew #"_" #lmul),
----------------
Should this string be emul instead of lmul?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148762/new/
https://reviews.llvm.org/D148762
More information about the llvm-commits
mailing list