[PATCH] D147270: [DebugInfo] Support more than 2 operands in DWARF operations

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 19 16:21:24 PDT 2023


scott.linder updated this revision to Diff 515123.
scott.linder edited the summary of this revision.
scott.linder added a comment.

Now that we are no longer contrained by constexpr, just use
SmallVector for everything.

Running 3 trials comparing `release/llvm-dwarfdump rel-with-deb-info/llc`
between this patch and trunk:

<stat>: <control> <patched> (<patched>/<control>)
instructions:u: 2053361427267 2053074326681 (0.999860)
Maximum resident set size: 5385686 5384477 (0.999776)
branches: 207788977127 208106839029 (1.001530)
branch-misses: 2480119693 2785843401 (1.123270)
User time: 254.363333 265.583333 (1.044110)

I haven't benchmarked LogicalView, but I suspect it should be similar.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147270/new/

https://reviews.llvm.org/D147270

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h
  llvm/include/llvm/DebugInfo/LogicalView/Core/LVLocation.h
  llvm/include/llvm/DebugInfo/LogicalView/Core/LVReader.h
  llvm/include/llvm/DebugInfo/LogicalView/Core/LVSymbol.h
  llvm/include/llvm/DebugInfo/LogicalView/Readers/LVCodeViewReader.h
  llvm/include/llvm/DebugInfo/LogicalView/Readers/LVELFReader.h
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  llvm/lib/DWARFLinker/DWARFLinker.cpp
  llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp
  llvm/lib/DebugInfo/LogicalView/Core/LVLocation.cpp
  llvm/lib/DebugInfo/LogicalView/Core/LVSymbol.cpp
  llvm/lib/DebugInfo/LogicalView/Readers/LVCodeViewReader.cpp
  llvm/lib/DebugInfo/LogicalView/Readers/LVCodeViewVisitor.cpp
  llvm/lib/DebugInfo/LogicalView/Readers/LVELFReader.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147270.515123.patch
Type: text/x-patch
Size: 23301 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230419/9941a78f/attachment-0001.bin>


More information about the llvm-commits mailing list