[PATCH] D148319: [compiler-rt] [test] [asan] Skip the static asan testsuites on mingw targets

Wed Apr 19 15:54:49 PDT 2023

vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.

In D148319#4271537 <https://reviews.llvm.org/D148319#4271537>, @mstorsjo wrote:

> In D148319#4271087 <https://reviews.llvm.org/D148319#4271087>, @alvinhochun wrote:
>
>> Originally I was thinking of just marking the test as unsupported in `compiler-rt\test\asan\lit.cfg.py`.
>
> Yes, that was my initial thought also, but then when I started looking around how these test suites were set up, I realized that this actually was kinda straightforward (in one sense). I later did try to do it that way too, but it had a couple complications. I can post the patches for that anyway, for comparisons.
>
>> Looking through CMakeLists.txt the change seems quite confusing. Why does the suspicious looking variable `COMPILER_RT_ASAN_HAS_STATIC_RUNTIME` not work, and why does it guard the dynamic asan tests instead of the static asan tests that we have to do the opposite of what it does for `MINGW`?
>
> Yeah that variable seems quite surprisingly named compared to the rest, but I kinda don't want to try to untangle that...

Maybe this will help 969902b43b0c028d49dba8ee0b443351fa0453cb

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148319/new/

https://reviews.llvm.org/D148319