[PATCH] D148732: [SLP][NFC] Test showing a cost estimation issue caused by f82eb7e066f322a231627383fc80522d98ce6181

[Vasileios Porpodas via Phabricator via llvm-commits]

vporpo added inline comments.


================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/buildvector-float-and-extract-lane1.ll:4
+
+; Building a vector of a float (lane 0) and an extract from lane 1 (lane 1)
+; should have a cost of +1 because we need an extra instruction to combine
----------------
ABataev wrote:
> vporpo wrote:
> > ABataev wrote:
> > > Add a cost analysis to the test.
> > What do you mean?
> Check llvm/test/Transforms/SLPVectorizer/X86/extractelement-multiple-uses.ll as an example
Is this getting updated automatically with update_test_checks.py? I had to add it by hand.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148732/new/

https://reviews.llvm.org/D148732