[PATCH] D147265: Update encodings in AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 19 13:31:14 PDT 2023


scott.linder removed reviewers: debug-info, dblaikie.
scott.linder added a comment.
This revision now requires review to proceed.

In D147265#4241322 <https://reviews.llvm.org/D147265#4241322>, @dblaikie wrote:

> Oh, naming though - DW_OP_LLVM_extension, perhaps? But I don't mind too much - the name isn't load bearing anyway, we can always rename it if we find a more descriptive name idf we're preserving the semantics

Yeah, I'm amenable to any name, the `user` naming was just to be similar to `DW_OP_{lo,hi}_user` as that is the feature from DWARF we are extending


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147265/new/

https://reviews.llvm.org/D147265



More information about the llvm-commits mailing list