[PATCH] D148568: [FuzzMutate] InsertFunctionStrategy

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/FuzzMutate/IRMutator.cpp:374
+  SmallVector<Instruction *, 32> Insts;
+  for (auto I = BB.getFirstInsertionPt(), E = BB.end(); I != E; ++I)
+    Insts.push_back(&*I);
----------------
Can use make_range(BB.getFirstInsertionPt(), BB.end())


================
Comment at: llvm/lib/FuzzMutate/RandomIRBuilder.cpp:426
+  if (RetTy != Type::getVoidTy(Context)) {
+    Instruction *RetAlloca = new AllocaInst(RetTy, 0, "RP", BB);
+    Instruction *RetLoad = new LoadInst(RetTy, RetAlloca, "", BB);
----------------
Missing alloca address space 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148568/new/

https://reviews.llvm.org/D148568