[PATCH] D142796: Flang semantic check support for tile and unroll OpenMP Directive.

[Abid via Phabricator via llvm-commits]

abidmalikwaterloo marked an inline comment as done.
abidmalikwaterloo added inline comments.


================
Comment at: flang/test/Semantics/OpenMP/omp-do-tile.f90:8
+	!ERROR: The parameter value in the Partial clause must be greater than one 
+	!$omp tile sizes(2, -2, 2) 
+	do i = 1,100
----------------
clementval wrote:
> kiranchandramohan wrote:
> > abidmalikwaterloo wrote:
> > > clementval wrote:
> > > > Can you add test with non-constant integer. The standard does precise that 
> > > > > size-list is a list s1,…,sn of positive integer expressions.
> > > Do you mean initialing a variable and then using it in the sizes clause: e.g. sizes (2, x, 2)?
> > Yeah, an expression like 2 + 2.
> > Also a variable that is defined as constant.
> > ```
> > integer, parameter :: x = -3
> > !$omp unroll partial(x)
> > ...
> > ```
> > Do you mean initialing a variable and then using it in the sizes clause: e.g. sizes (2, x, 2)?
> 
> yes
Already included for tiles. Will include a test for unrolling as well


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142796/new/

https://reviews.llvm.org/D142796