[PATCH] D148568: [FuzzMutate] InsertFunctionStrategy

[Peter Rong via Phabricator via llvm-commits]

Peter added inline comments.


================
Comment at: llvm/lib/FuzzMutate/IRMutator.cpp:346
+  // If nullptr is selected, we will create a new function declaration.
+  SmallVector<Function *, 32> Functions({nullptr});
+  for (Function &F : M->functions()) {
----------------
arsenm wrote:
> Don't see the point of the initializer here
If the mutator select `nullptr`, we can create a new function. This is to give us a chance to define more functions.


================
Comment at: llvm/lib/FuzzMutate/IRMutator.cpp:359
+  SmallVector<fuzzerop::SourcePred, 2> SourcePreds;
+  if (F->arg_size() != 0) {
+    for (Type *ArgTy : FTy->params()) {
----------------
arsenm wrote:
> arg_empty
Fixed, thanks for pointint out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148568/new/

https://reviews.llvm.org/D148568