[PATCH] D148225: ValueTracking: Handle shufflevector in computeKnownFPClass

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4610
+    APInt DemandedLHS, DemandedRHS;
+    auto *Shuf = dyn_cast<ShuffleVectorInst>(Op);
+    if (!Shuf || !getShuffleDemandedElts(Shuf, DemandedElts, DemandedLHS, DemandedRHS))
----------------
arsenm wrote:
> foad wrote:
> > `cast` not `dyn_cast`
> Shufflevector constant expressions do exist though I couldn’t figure out how to get one to reach here, so it’s better to leave it as is 
Fair enough - but maybe getShuffleDemandedElts should handle them too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148225/new/

https://reviews.llvm.org/D148225