[PATCH] D147620: [DebugInfo] Keep the CU consistent for operating `DISubprogram`.

Wed Apr 19 00:57:04 PDT 2023

nikic added a comment.

In D147620#4279004 <https://reviews.llvm.org/D147620#4279004>, @dblaikie wrote:

> Also the LLVM UIR in the test case seems strange to me - I guess you've put DISubprogram dedfinitions scoped within the type declaration?

I looked around a bit, and I think the answer is yes based on this comment: https://github.com/rust-lang/rust/blob/c7815840793b980d0aae7d5a2f5d9bb1fd6c0d1e/compiler/rustc_codegen_llvm/src/debuginfo/mod.rs#L502-L504 Looking through blame, this was implemented in https://github.com/rust-lang/rust/pull/33358 to fix https://github.com/rust-lang/rust/issues/33192. I don't know anything about DWARF, so can't comment on whether that was the right/wrong solution.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147620/new/

https://reviews.llvm.org/D147620