[PATCH] D148661: [SCEV] Common code for computing trip count in a fixed type [NFC-ish]

Joshua Cao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 21:24:11 PDT 2023


caojoshua added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:994
+  const SCEV *TripCountSCEV =
+    SE->getTripCountFromExitCount(BECount, IntPtr, CurLoop);
   return SE->getMulExpr(TripCountSCEV,
----------------
craig.topper wrote:
> caojoshua wrote:
> > craig.topper wrote:
> > > Isn't clang-format for line wrap 4 spaces of indention?
> > I think 2 spaces is correct. If I run 
> > 
> > ```
> > clang-format -style=llvm -dump-config > .clang-format
> > ```
> > 
> > I see `IndentWidth: 2` and `UseTab: Never`
> The value I'm thinking of might be `ContinuationIndentWidth = 4; `
OK yeah I think you're right. Should be 4 spaces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148661/new/

https://reviews.llvm.org/D148661



More information about the llvm-commits mailing list