[PATCH] D147584: [lld] Support separate minimized bitcode file path in --thinlto-prefix-replace

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/COFF/Config.h:234
+  // directory as the full bitcode files
+  llvm::StringRef thinLTOPrefixReplaceFullBitcode;
+  llvm::StringRef thinLTOPrefixReplaceOutput;
----------------
Perhaps it's clearer to name all variables `thinLTOPrefixReplace*Dir`, e.g. `thinLTOPrefixReplace{Full,Index,Obj,Minimized}Dir`?


================
Comment at: lld/COFF/Driver.cpp:94
 
-// Parse options of the form "old;new[;extra]".
-static std::tuple<StringRef, StringRef, StringRef>
+// Parse options of the form "old;new[;extra][;extra2]".
+static std::tuple<StringRef, StringRef, StringRef, StringRef>
----------------
Perhaps `full;index[;obj][;minimized]`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147584/new/

https://reviews.llvm.org/D147584