[PATCH] D148610: Clean come dead code

Wang, Xin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 18:53:40 PDT 2023


XinWang10 added inline comments.


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:1620
     std::pair<StringRef, StringRef> Split;
     if (!MAI.useParensForSymbolVariant()) {
-      if (FirstTokenKind == AsmToken::String) {
----------------
skan wrote:
> Assert `FirstTokenKind != AsmToken::String`?
It's not necessary, FirstTokenKind should always be one of one of AsmToken::Dollar, AsmToken::At and AsmToken::Identifier and never be AsmToken::String. can refer to line 1580


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148610/new/

https://reviews.llvm.org/D148610



More information about the llvm-commits mailing list