[PATCH] D148607: Add support for writing binary ELF doc nodes

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 11:59:24 PDT 2023


scott.linder accepted this revision.
scott.linder added a comment.
This revision is now accepted and ready to land.

LGTM with 1 small nit



================
Comment at: llvm/include/llvm/BinaryFormat/MsgPackDocument.h:380
+  DocNode getNode(MemoryBufferRef V, bool Copy = false) {
+    auto raw = V.getBuffer();
+    if (Copy)
----------------
Local should be `CamelCase`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148607/new/

https://reviews.llvm.org/D148607



More information about the llvm-commits mailing list