[PATCH] D148646: [AArch64] Remove dead tryMLAV64LaneV128 and tryMULLV64LaneV128 code. NFC

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 10:25:23 PDT 2023


dmgreen created this revision.
dmgreen added reviewers: t.p.northover, efriedma, SjoerdMeijer, jaykang10, samtebbs.
Herald added subscribers: ctetreau, hiraditya, kristof.beyls.
Herald added a project: All.
dmgreen requested review of this revision.
Herald added a project: LLVM.

As far as I can tell this code is never used, as the pattern recognised by checkHighLaneIndex (an duplane with insert_subvec and extract_subvec) will not be generated any more. There are no tests that change from removing it (including the clang neon tests), and it didn't appear to come up in any benchmarks I ran. There are already existing patterns for MLA with index and s/umull with index.

Removing it also prevents it from causing problems for SVE, as in #62151.


https://reviews.llvm.org/D148646

Files:
  llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148646.514673.patch
Type: text/x-patch
Size: 5718 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230418/a461f2b7/attachment.bin>


More information about the llvm-commits mailing list