[PATCH] D145516: [Inliner] Avoid excessive inlining through devirtualised calls

[Jeremy Morse via Phabricator via llvm-commits]

jmorse updated this revision to Diff 514652.
jmorse added a comment.

No worries; thanks for the review, I've adopted the revised test and filter for adding the attribute.

(The extra code in the previous review turns out to be un-needed. I'd managed to confuse myself while backporting rG53e5e586709 <https://reviews.llvm.org/rG53e5e586709a329370ea268a8e8191b16fd641b7> to an old release to see if affected the issue we were experiencing, I had made the attribute a function attribute rather than call. Whoops. The shorter filter works just fine.)

For the test checks, I'm now checking for both the attribute and the inlined function body, just in case the attribute ceases to have the same effect on inlining decisions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145516/new/

https://reviews.llvm.org/D145516

Files:
  llvm/lib/Analysis/InlineCost.cpp
  llvm/lib/Transforms/IPO/Inliner.cpp
  llvm/test/Transforms/Inline/devirtualize-7.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145516.514652.patch
Type: text/x-patch
Size: 5510 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230418/3074b104/attachment.bin>