[PATCH] D148610: Clean come dead code

[Wang, Xin via Phabricator via llvm-commits]

XinWang10 added inline comments.


================
Comment at: llvm/lib/CodeGen/IfConversion.cpp:535
         if (DisableTriangleF && isFalse && !isRev) break;
-        if (DisableTriangleFR && isFalse && isRev) break;
         LLVM_DEBUG(dbgs() << "Ifcvt (Triangle");
----------------
skan wrote:
> XinWang10 wrote:
> > XinWang10 wrote:
> > > craig.topper wrote:
> > > > skan wrote:
> > > > > Should we add an assertion `!(isFalse && isRev)` here?
> > > > Does this mean DisableTriangleFR is also dead?
> > > No, DisableTriangleFR is a option specified by user. Perhaps we'd better just remove isFalse && isRev.
> > add an assertion !(isFalse && isRev), I think it doesn't make sense here, just add another dead code?
> I believe assertion is ignored for dead code.  But I agree with you, the assertion is useless here b/c the definitions of `isRev` and 'isFalse' are nearby。
> Does this mean DisableTriangleFR is also dead?

I get your point now, I try to search for it, seems it also die.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148610/new/

https://reviews.llvm.org/D148610